Patch Acceptance Process
- Read the Bazel governance plan.
- Discuss your plan and design, and get agreement on a GitHub issue or our mailing list.
- PRs that change or add behavior are not accepted without being tied to an issue.
- Significant changes need a design document.
- Prepare a git commit that implements the feature. Don’t forget to add tests and update the documentation.
- Ensure you’ve signed a Contributor License Agreement.
- Send us a pull request on GitHub. If you’re new to GitHub, read about pull requests. Note that we restrict permissions to create branches on the main Bazel repository, so you will need to push your commit to your own fork of the repository.
- Wait for a Bazel team member to assign you a reviewer. It should be done in 2 business days (excluding holidays in the USA and Germany). If you do not get a reviewer within that time frame, you can ask for one by sending a mail to email@example.com.
- Work with the reviewer to complete a code review. For each change, create a new commit and push it to make changes to your pull request. If the review takes too long (e.g. reviewer is unresponsive), please also send an email to firstname.lastname@example.org.
A Bazel maintainer at Google will apply the patch to our internal version control system.
This triggers internal presubmit checks that may suggest more changes. If you haven’t expressed a preference, the submitter will automatically add “trivial” changes (like linting) that don’t affect design. If deeper changes are required or you’d prefer to apply changes directly, you and the reviewer should communicate preferences clearly in review comments.
After internal submission, the patch is exported as a Git commit, at which point the GitHub pull request is closed. All final changes are attributed to you.